Date: Thu, 24 Nov 2016 23:27:04 +0100 From: Jakub Klama <jakub@ixsystems.com> To: Ian Lepore <ian@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309121 - head/usr.sbin/bhyve Message-ID: <7F692FF4-4F36-4ED8-AF26-4684D41CB3AE@ixsystems.com> In-Reply-To: <1480026232.1889.63.camel@freebsd.org> References: <201611242216.uAOMGIi0065703@repo.freebsd.org> <1480026232.1889.63.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Wiadomość napisana przez Ian Lepore <ian@FreeBSD.org> w dniu 24.11.2016, o godz. 23:23: > > On Thu, 2016-11-24 at 22:16 +0000, Jakub Wojciech Klama wrote: >> Author: jceel >> Date: Thu Nov 24 22:16:18 2016 >> New Revision: 309121 >> URL: https://svnweb.freebsd.org/changeset/base/309121 >> >> Log: >> virtio_console: handle short writes to an Unix domain socket >> gracefully. >> >> writev() can do a short write. Retrying it results in a very >> convoluted >> and complex code, so we iterate over iovec and do regular >> stream_write() >> instead. >> > > Doesn't pwritev(2) simplify iterating to handle short writes? > Correct me if I'm wrong, but pwritev(2) is a writev(2) with offset. We're writing to an Unix domain socket here, which is not seekable. Thanks, Jakub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7F692FF4-4F36-4ED8-AF26-4684D41CB3AE>