Date: Wed, 27 Jan 1999 21:56:31 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "Justin T. Gibbs" <gibbs@plutotech.com> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/eisa ahb.c Message-ID: <199901280556.VAA93512@apollo.backplane.com> References: <199901280332.UAA25969@pluto.plutotech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:>
:> Modified files:
:> sys/i386/eisa ahb.c
:> Log:
:> Fix parenthesization, but the code still looks wrong.
:>
:> Revision Changes Path
:> 1.5 +7 -2 src/sys/i386/eisa/ahb.c
:
:There certainly was a bug there, but your commit made the driver
:non-functional. Why not pass your concern on to the author/maintainer of
:the driver instead of committing something that does not address the
:problem? If I had missed your checkin mail, I would never have noticed the
:bug especially after you cleared the compiler warning without really fixing
:the problem.
:
:I've committed a proper fix.
:
:--
:Justin
The discussion was moved to the scsi list, and I still had it
dogeared but you are right - I probably should not have committed
the parenthesization fix.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280556.VAA93512>