Date: Wed, 24 May 2017 12:26:00 -0400 From: Ed Maste <emaste@freebsd.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: Konstantin Belousov <kib@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi... Message-ID: <CAPyFy2D0rJR27G-L8-KZLhao=3WZziXhSXdt7JhiyhaT_KsDPg@mail.gmail.com> In-Reply-To: <c3040c70-6fc4-ac91-a887-f63bf4656a8e@FreeBSD.org> References: <201705230929.v4N9T5g1028124@repo.freebsd.org> <c3040c70-6fc4-ac91-a887-f63bf4656a8e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 May 2017 at 10:53, Pedro Giffuni <pfg@freebsd.org> wrote: > > There is now a bunch of coverity issues (OVERFLOW_BEFORE_WIDEN mostly) > tied to ino64_t. At least the following CIDs are related: On a quick look the OVERFLOW_BEFORE_WIDEN issues are false positives in practice: for correct operation the product must fit within 32 bits, because inodes were previously 32 bits. However, it does seem unusual to perform a multiplication with types that could overflow 32 bits, and then store the result in a 64-bit variable. So it seems that a code change to eliminate the warning is likely reasonable.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2D0rJR27G-L8-KZLhao=3WZziXhSXdt7JhiyhaT_KsDPg>