Date: Fri, 11 Jan 2019 11:04:10 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Lars Engels <lme@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config Message-ID: <CANCZdfp7hB9V90niJd-_h1M%2B9EaajaNNTUdezBKemJE%2BS9eMeQ@mail.gmail.com> In-Reply-To: <201901111710.x0BHAXsr022139@pdx.rh.CN85.dnsmgr.net> References: <20190111164754.GB1267@e.0x20.net> <201901111710.x0BHAXsr022139@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > > > The style of this .sh does not match the normal style of > > > such things in base, especially with respect to long lines > > > and indentation. > > > > Do we have a style guide for shell scripts in base? How should > > indentation look like? > > Not that I can locate, but I can state that almost all > of the base code uses tab indenting and limited to 80 > column widths, independent of c, sh, make, etc. > We have a style.Makefile, style, style.mdoc and style.lua man pages. Maybe it's time for style.sh, eh? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp7hB9V90niJd-_h1M%2B9EaajaNNTUdezBKemJE%2BS9eMeQ>