Date: Tue, 26 Jul 2016 13:03:01 -0400 From: Ed Maste <emaste@freebsd.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r303338 - head/sys/dev/vt Message-ID: <CAPyFy2AwpsnttmcrmX4UPo=1X-2Z97_sK6gUEqoD_Db6Yr-hQA@mail.gmail.com> In-Reply-To: <CABh_MKm9eQc5fdPxDu2i_F7BUa4sasB_iy3w67_q9g__OThUoQ@mail.gmail.com> References: <201607261534.u6QFYQ9L017045@repo.freebsd.org> <CABh_MKm9eQc5fdPxDu2i_F7BUa4sasB_iy3w67_q9g__OThUoQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 July 2016 at 12:27, Ed Schouten <ed@nuxi.nl> wrote:
> Hi Ed,
>
> 2016-07-26 17:34 GMT+02:00 Ed Maste <emaste@freebsd.org>:
>> if (vw == vd->vd_curwindow) {
>> + mtx_lock(&Giant);
>> kbd = kbd_get_keyboard(vd->vd_keyboard);
>> if (kbd != NULL)
>> vt_save_kbd_state(vw, kbd);
>> + mtx_unlock(&Giant);
>> }
>
> Would it make sense to put an mtx_assert(&Giant, MA_OWNED) in
> kbd_get_keyboard()?
Yes, I made that change locally and also intend to review
kbd_get_keyboard's callers. I didn't commit it to HEAD right away to
avoid mass breakage if there's missing locking.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2AwpsnttmcrmX4UPo=1X-2Z97_sK6gUEqoD_Db6Yr-hQA>