Date: Mon, 16 Jan 2012 22:04:39 +0300 From: Veniamin Gvozdikov <g.veniamin@googlemail.com> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: Max Brazhnikov <makc@freebsd.org>, Axel Gonzalez <loox@e-shell.net>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp Message-ID: <CAKc_ii3y1YRQ9UO3gv5zYxyhnTOhAtth1xt5LVZwdb4ibV7tMg@mail.gmail.com> In-Reply-To: <4F1472E7.3010309@yandex.ru> References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org> <201201161838.12941.makc@freebsd.org> <4F1472E7.3010309@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm agree. 2012/1/16 Ruslan Mahmatkhanov <cvs-src@yandex.ru>: > Max Brazhnikov wrote on 16.01.2012 22:38: > >> On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote: >>> >>> rm =A0 =A0 =A0 =A0 =A02012-01-13 03:38:22 UTC >>> >>> =A0 FreeBSD ports repository >>> >>> =A0 Modified files: >>> =A0 =A0 audio/clementine-player Makefile >>> =A0 Added files: >>> =A0 =A0 audio/clementine-player/files patch-src-devices-cddadevice.h >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 pat= ch-src-devices-cddalister.cpp >>> =A0 Log: >>> =A0 - let it build with stock gcc >>> =A0 - optionify ipod and mtp support (default on) >> >> >> This type of `port optionification' leads to a nasty problem of hidden >> dependencies when options are unchecked, but corresponding libraries are >> presented. Please consider to commit the patch, which makes optional >> support >> really optional. >> >> Max > > > You are right, thank you. > Veniamin, do you have any objections if this patch will be committed? > > -- > Regards, > Ruslan > > Tinderboxing kills... the drives. --=20 Phone: +7 916 948 58 30 Site: http://zlonet.ru OpenGPG: g.veniamin(at)googlemail(dot)com | 9B9E5154 XMMP: zloidemon(at)jabber(dot)ru | 19B4A605
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKc_ii3y1YRQ9UO3gv5zYxyhnTOhAtth1xt5LVZwdb4ibV7tMg>