Date: Wed, 21 Jun 2017 22:02:19 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: TAKAHASHI Yoshihiro <nyan@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r317591 - head/sys/dev/drm2/radeon Message-ID: <61cac4d7-0710-1f5e-8268-42b441b3b6ba@FreeBSD.org> In-Reply-To: <20170611.000714.2063715294250192258.nyan@FreeBSD.org> References: <201704290947.v3T9lF0r075921@repo.freebsd.org> <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> <20170611.000714.2063715294250192258.nyan@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/06/2017 18:07, TAKAHASHI Yoshihiro wrote: > In article <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> > Andriy Gapon <avg@FreeBSD.org> writes: > >> On 29/04/2017 12:47, Takahashi Yoshihiro wrote: >>> Author: nyan >>> Date: Sat Apr 29 09:47:15 2017 >>> New Revision: 317591 >>> URL: https://svnweb.freebsd.org/changeset/base/317591 >>> >>> Log: >>> Add TUNABLE_INT to radeonkms driver parameters. >>> They are required by PowerMac G5 DP. >>> >>> PR: 217852 >>> Submitted by: Hiroo Ono >>> MFC after: 1 week >> >> I think that this solution that I had in my private tree is a little bit more >> powerful: >> https://people.freebsd.org/~avg/radeon_drv-knobs.diff >> >> The advantage is that it is less intrusive and also provides read-only sysctl in >> addition to the tunables. >> Also, hw.drm.radeon seems like a better place for the knobs than just drm.radeon. >> >> Do you mind if I commit this? > > Sorry for late. > > I don't mind that your suggestion. But if you will commit the patch, > I think that you should apply the same way to the i915 driver. Ooh, I didn't realize that there was a precedent and that "drm" was already used as a root for tunables. So, not sure if I want to pursue this further... Thank you! -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?61cac4d7-0710-1f5e-8268-42b441b3b6ba>