Date: Mon, 10 Oct 2005 16:10:21 GMT From: Panagiotis Astithas <past@ebs.gr> To: freebsd-eclipse@FreeBSD.org Subject: Re: ports/86860: [patch] Align java/eclipse invocation with javavmwrapper Message-ID: <200510101610.j9AGALDD002440@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/86860; it has been noted by GNATS.
From: Panagiotis Astithas <past@ebs.gr>
To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/86860: [patch] Align java/eclipse invocation with javavmwrapper
Date: Mon, 10 Oct 2005 19:02:52 +0300
Herve Quiroz wrote:
> Hi,
>
> I am a bit late on this topic (PR already closed) but I just noticed a
> flaw with this change.
>
> javavmwrapper picks a JDK depending on several variables -- see
> javavm(1). With this change it is possible that a not suitable JDK gets
> picked up. Here is a patch that should fix this (I didn't test it
> though).
>
>
> Index: files/eclipse.in
> ===================================================================
> RCS file: /home/ncvs/ports/java/eclipse/files/eclipse.in,v
> retrieving revision 1.5
> diff -u -r1.5 eclipse.in
> --- files/eclipse.in 9 Oct 2005 14:54:21 -0000 1.5
> +++ files/eclipse.in 10 Oct 2005 14:54:13 -0000
> @@ -46,4 +46,4 @@
> exit 1
> fi
>
> -PATH=${JAVA_HOME}/bin:$PATH exec "${ECLIPSE_HOME}/eclipse" $@
> +JAVA_VERSION="%%JAVA_VERSION%%" JAVA_OS="%%JAVA_OS%%" PATH=${JAVA_HOME}/bin:$PATH exec "${ECLIPSE_HOME}/eclipse" $@
Why do you think this is necessary? What the eclipse executable does is
invoke the java executable it finds in the PATH. Since we have made sure
the javavmwrapper's symlink will get chosen as the default, it will
honour the JAVA_VERSION and JAVA_OS variables, right? Am I missing
something here?
Regards,
Panagiotis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510101610.j9AGALDD002440>