Date: Sun, 16 Mar 2014 14:15:02 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Mark R V Murray <mark@grondar.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r263218 - in head: lib/libcrypt lib/libmd sys/conf sys/crypto/sha2 Message-ID: <20140316211501.GE32089@funkthat.com> In-Reply-To: <08A216A5-BE59-4505-AA13-2B7E026DB56A@grondar.org> References: <201403160143.s2G1hOV8093665@svn.freebsd.org> <08A216A5-BE59-4505-AA13-2B7E026DB56A@grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Murray wrote this message on Sun, Mar 16, 2014 at 17:24 +0000:
> I haven?t looked at this closely, but if you?ve dropped support for sha256, then sys/dev/random/... can?t use it :-(
Please read closer... To many things would break if sha256 was really
removed...
> On 16 Mar 2014, at 01:43, John-Mark Gurney <jmg@FreeBSD.org> wrote:
> > replace the kernel's version w/ cperciva's implementation... In all
> > my tests, it is faster ~20%, even on an old IXP425 533MHz it is ~45%
> > faster... This is partly due to loop unrolling, so the code size does
> > significantly increase... I do plan on committing a version that
> > rolls up the loops again for smaller code size for embedded systems
> > where size is more important than absolute performance (it'll save ~6k
> > code)...
> >
> > The kernel implementation is now shared w/ userland's libcrypt and
> > libmd...
> >
> > We drop support for sha256 from sha2.c, so now sha2.c only contains
> > sha384 and sha512...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140316211501.GE32089>