Date: Wed, 30 May 2018 10:41:22 +0000 From: Antoine Brodin <antoine@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool Message-ID: <CAALwa8k4Vxwi_djFGCdZQ2o_OrVJHumJ4Khj3E6dZitdEEc8Eg@mail.gmail.com> In-Reply-To: <c4440e7a-0fb1-df27-0940-6093cf2ca7ca@selasky.org> References: <201805280812.w4S8CI56046943@repo.freebsd.org> <CAALwa8n-UUS8kHmWpiGxKGBWbu4epzTCeusMPg9-FpyMaWS%2BGw@mail.gmail.com> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> <CAALwa8nEAh0Xny8_YF%2B4bdCU7tDQo84-kJBcot6ZPAg9Zi9TDg@mail.gmail.com> <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> <CAALwa8kMsiLxaaRgfw-qGrSfZhv2ov9wj_K3fEtRkqUnG7o0YQ@mail.gmail.com> <56e03042-872c-36df-4fea-d22a09d7ffca@selasky.org> <CAALwa8n5Lc0fvP6ec2F8Bnc7BnVDP05VT1GUtD6hsVFg68U8Ow@mail.gmail.com> <c4440e7a-0fb1-df27-0940-6093cf2ca7ca@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 30, 2018 at 9:42 AM, Hans Petter Selasky <hps@selasky.org> wrote: > On 05/30/18 11:00, Antoine Brodin wrote: >> >> On Wed, May 30, 2018 at 8:20 AM, Hans Petter Selasky <hps@selasky.org> >> wrote: >>> >>> On 05/30/18 10:02, Antoine Brodin wrote: >>>> >>>> >>>> Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE >>>> as it previously had? >>> >>> >>> >>> The HAVE_REMOTE was removed upstream: >>> >>> >>> https://github.com/the-tcpdump-group/libpcap/commit/a372536befc9b1ee1d355058daa2eb9f66aa0c59#diff-46964bcbd8e8a5cec9a75c66ab26a97b >>> >>> What do you think? Shall we re-add it to base? > > > Hi, >> >> Either hide remote packet capture functions from the header or enable >> remote capture functions? > > > This feature is disabled by default for UNIX. > >> Note that net/p5-Net-Pcap will fail to build with libpcap from ports >> too when libpcap from ports is updated to version 1.9.0 (pre-release). > > > No, libpcap from ports has own header files and libraries and does not use > anything from libpcap in base. > > Enabling remote packet capture in libcap won't solve the build failure. > > The right solution from my point of view is to extend the BUILD_DEPENDS and > CFLAGS and LDFLAGS like shown: > > BUILD_DEPENDS= p5-IO-Interface>=0:net/p5-IO-Interface \ > libpcap>=0:net/libpcap > > CFLAGS+= -I${PREFIX}/include > LDFLAGS+= -L${PREFIX}/lib > > After the upgrade to 1.9.0 (pre-release) in ports you simply add: > > CFLAGS+= -DHAVE_PCAP_SETSAMPLING -DHAVE_PCAP_OPEN No this won't solve the issue, libpcap from ports isn't compiled with remote support. Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8k4Vxwi_djFGCdZQ2o_OrVJHumJ4Khj3E6dZitdEEc8Eg>