Date: Wed, 23 Jun 2010 20:26:47 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: xcllnt@mac.com Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, nwhitehorn@freebsd.org Subject: Re: svn commit: r209490 - head/sys/kern Message-ID: <20100623.202647.867924114552092597.imp@bsdimp.com> In-Reply-To: <3659E546-80A0-4E82-8112-40B093728D81@mac.com> References: <201006232326.o5NNQEtK011793@svn.freebsd.org> <3659E546-80A0-4E82-8112-40B093728D81@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <3659E546-80A0-4E82-8112-40B093728D81@mac.com>
Marcel Moolenaar <xcllnt@mac.com> writes:
:
: On Jun 23, 2010, at 4:26 PM, Nathan Whitehorn wrote:
:
: > @@ -53,7 +53,7 @@ __FBSDID("$FreeBSD$");
: > */
: >
: > #ifndef HZ
: > -# if defined(__amd64__) || defined(__i386__) || defined(__ia64__) || defined(__sparc64__)
: > +# if defined(__amd64__) || defined(__i386__) || defined(__ia64__) || defined(__sparc64__) || defined(__powerpc__)
: > # define HZ 1000
: > # else
: > # define HZ 100
:
: Would you mind inverting the #if statement? The common case is
: obviously 1KHz, so listing the exceptions (I belief that's only
: arm and mips) is more effective...
Shouldn't this be defined in some file in ARCH/include instead?
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100623.202647.867924114552092597.imp>