Date: Tue, 27 Jan 2015 20:29:18 -0700 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, =?windows-1252?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk Message-ID: <35AB8592-7ACA-4352-8448-F7EFA0F861CD@bsdimp.com> In-Reply-To: <F9F10CE5-3282-4BDF-AA65-9FF1F994412E@gmail.com> References: <201501260850.t0Q8oDna015719@svn.freebsd.org> <86fvax91cy.fsf@nine.des.no> <F9F10CE5-3282-4BDF-AA65-9FF1F994412E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 26, 2015, at 7:26 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote: > > On Jan 26, 2015, at 4:23, Dag-Erling Smørgrav <des@des.no> wrote: > >> Garrett Cooper <ngie@FreeBSD.org> writes: >>> Log: >>> Honor MK_ACCT with etc/pam.d/atrun >> >> The correct idiom would be > > I disagree for a few reasons: > 1. style.Makefile(9) makes no mention of having to use an idiom over the other. > 2. The likelihood of typos creeping into Makefiles is greater with the _foo= idiom. > 3. It creates unnecessary local variables — especially when appending is so easy to do. > 4. It’s more difficult when backporting changes to do it with the variable method — especially if context around the line modified has changed a great deal. 5. I’m working on a change that would be easier to do with Garrett’s change, but it is rather invasive so I need to work it through a good chunk of the system before I offer it for review and discussion. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35AB8592-7ACA-4352-8448-F7EFA0F861CD>