Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Aug 2021 18:44:54 +0200
From:      Mateusz Guzik <mjguzik@gmail.com>
To:        Ka Ho Ng <khng@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: a48416f844e3 - main - tmpfs: Fix error being cleared after commit c12118f6cec0
Message-ID:  <CAGudoHHm586ViAH=hrpmEVDF--Vw4nBiktEbgm8rwTmgrQe3bA@mail.gmail.com>
In-Reply-To: <202108241637.17OGbGVi074299@gitrepo.freebsd.org>
References:  <202108241637.17OGbGVi074299@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/24/21, Ka Ho Ng <khng@freebsd.org> wrote:
> The branch main has been updated by khng:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=a48416f844e3007b4e9f6df125e25cf3a1daad62
>
> commit a48416f844e3007b4e9f6df125e25cf3a1daad62
> Author:     Ka Ho Ng <khng@FreeBSD.org>
> AuthorDate: 2021-08-24 16:35:29 +0000
> Commit:     Ka Ho Ng <khng@FreeBSD.org>
> CommitDate: 2021-08-24 16:35:29 +0000
>
>     tmpfs: Fix error being cleared after commit c12118f6cec0
>
>     In tmpfs_link() error was erroneously cleared in commit c12118f6cec0.
>
>     Sponsored by:   The FreeBSD Foundation
>     MFC after:      3 days
>     MFC with:       c12118f6cec0
> ---
>  sys/fs/tmpfs/tmpfs_vnops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sys/fs/tmpfs/tmpfs_vnops.c b/sys/fs/tmpfs/tmpfs_vnops.c
> index 325b8d2789bb..326a5132990d 100644
> --- a/sys/fs/tmpfs/tmpfs_vnops.c
> +++ b/sys/fs/tmpfs/tmpfs_vnops.c
> @@ -808,7 +808,7 @@ tmpfs_link(struct vop_link_args *v)
>  	error = 0;
>
>  out:
> -	return (0);
> +	return (error);
>  }
>

You should use coccinelle for changs like this.

>  /*
>


-- 
Mateusz Guzik <mjguzik gmail.com>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHHm586ViAH=hrpmEVDF--Vw4nBiktEbgm8rwTmgrQe3bA>