Date: Sun, 24 Nov 2019 10:32:23 -0600 From: "Brandon Bergren" <freebsd@bdragon.rtk0.net> To: "Konstantin Belousov" <kostikbel@gmail.com>, "Justin Hibbits" <jhibbits@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355045 - head/libexec/rtld-elf/powerpc Message-ID: <849a4306-1cf7-4296-b594-236caa1572a0@www.fastmail.com> In-Reply-To: <20191124130441.GA2707@kib.kiev.ua> References: <201911240435.xAO4ZTgw070233@repo.freebsd.org> <20191124130441.GA2707@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 24, 2019, at 7:04 AM, Konstantin Belousov wrote: > On Sun, Nov 24, 2019 at 04:35:29AM +0000, Justin Hibbits wrote: > > Author: jhibbits > > Date: Sun Nov 24 04:35:29 2019 > > New Revision: 355045 > > URL: https://svnweb.freebsd.org/changeset/base/355045 > > > > Log: > > rtld/powerpc: Fix _rtld_bind_start for powerpcspe > > > > Summary: > > We need to save off the full 64-bit register, not just the low 32 bits, > > of all registers getting saved off in _rtld_bind_start. Additionally, > > we need to save off the other SPE registers (SPEFSCR and accumulator), > > so that their program state is not affected by the PLT resolver. > Why do you need to save these registers ? Why would rtld touch them ? > Out of a need to make the binder as invisible as possible when interacting with code that may or may not be following the normal ABI rules regarding who is responsible for saving stuff. It's not just C code using it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?849a4306-1cf7-4296-b594-236caa1572a0>