Date: Wed, 9 Jan 2008 11:26:19 +0100 (CET) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/119483: vidcontrol miss latest VESA mode (off-by-one bug) Message-ID: <200801091026.m09AQJhf049433@kulesh.obluda.cz> Resent-Message-ID: <200801091030.m09AU2V7041312@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119483
>Category: bin
>Synopsis: vidcontrol miss latest VESA mode (off-by-one bug)
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 09 10:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 6.3-PRERELEASE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #0: Mon Jan 7 20:31:37 CET 2008 root@:/usr/obj/usr/src/sys/KULESH i386
src/usr.sbin/vidcontrol/vidcontrol.c,v 1.52.2.2 2006/10/04 06:09:11
>Description:
vidcontrol -i mode
miss the mode 0x1ff=M_VESA_MODE_MAX in listing due off-by-one bug
The M_VESA_MODE_MAX is latest valid mode - not the first invalid
>How-To-Repeat:
use vidcontrol -i mode on hardware which has 0x1ff mode - it will
not be listed
>Fix:
--- /usr/src/usr.sbin/vidcontrol/vidcontrol.c.ORIG 2008-01-09 11:20:05.000000000 +0100
+++ /usr/src/usr.sbin/vidcontrol/vidcontrol.c 2008-01-09 11:20:35.000000000 +0100
@@ -960,7 +960,7 @@
printf("---------------------------------------"
"---------------------------------------\n");
- for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) {
+ for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) {
_info.vi_mode = mode;
if (ioctl(0, CONS_MODEINFO, &_info))
continue;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801091026.m09AQJhf049433>