Date: Tue, 6 Dec 2005 03:20:07 +0000 From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 bpf_jit_machdep.c bpf_jit_machdep.h src/sys/conf files files.amd64 files.i386 options.amd64 options.i386 src/sys/i386/i386 bpf_jit_machdep.c bpf_jit_machdep.h src/sys/net bpf.c bpf_jitter.c bpf_jitter.h bpfdesc.h Message-ID: <20051206032007.GB70151@freefall.freebsd.org> In-Reply-To: <200512060258.jB62wCnk084452@repoman.freebsd.org> References: <200512060258.jB62wCnk084452@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 06, 2005 at 02:58:12AM +0000, Jung-uk Kim wrote:
>
> Revision Changes Path
[..]
> 1.162 +54 -3 src/sys/net/bpf.c
> 1.1 +85 -0 src/sys/net/bpf_jitter.c (new)
> 1.1 +80 -0 src/sys/net/bpf_jitter.h (new)
[..]
BPFD_LOCK(d);
if (wfilter)
d->bd_wfilter = fcode;
else {
d->bd_rfilter = fcode;
#if BPF_JITTER
d->bd_bfilter = bpf_jitter(fcode, flen);
#endif
You are calling bpf_jitter() with a mutex held, and it looks like
bpf_jitter() will call malloc with M_WAITOK. Are you sure you want
to do this?
--
Christian S.J. Peron
csjp@FreeBSD.ORG
FreeBSD Committer
FreeBSD Security Team
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051206032007.GB70151>