Date: Thu, 21 Jul 2011 13:55:15 +0100 From: Shaun Amott <shaun@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: www/en/cgi Makefile www/share/mk web.site.mk Message-ID: <20110721125514.GA57642@charon.picobyte.net> In-Reply-To: <20110721.123130.698363444164784046.hrs@allbsd.org> References: <201107202352.p6KNqCkN034366@repoman.freebsd.org> <20110721.123130.698363444164784046.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Jul 21, 2011 at 12:31:30PM +0900, Hiroki Sato wrote:
> Shaun Amott <shaun@FreeBSD.org> wrote
> in <201107202352.p6KNqCkN034366@repoman.freebsd.org>:
>
> sh> shaun 2011-07-20 23:52:12 UTC
> sh>
> sh> FreeBSD doc repository (ports committer)
> sh>
> sh> Modified files:
> sh> en/cgi Makefile
> sh> share/mk web.site.mk
> sh> Log:
> sh> Hook up files (Perl modules) for the new query-pr.cgi script. A bit of
> sh> extra code to handle the fact that the files are in subdirectories was
> sh> required.
> sh>
> sh> Revision Changes Path
> sh> 1.35 +14 -1 www/en/cgi/Makefile
> sh> 1.77 +9 -1 www/share/mk/web.site.mk
> sh>
>
> Thank you for updating the CGI script, but I do not think it is a
> good idea to add CGI_SUB{DIRS,FILES} into web.site.mk.
> Sub-directories are handled by bsd.subdir.mk, so it should be used in
> straightforward way instead of adding new variables/targets.
>
> What do you think about the attached patch? I did not notice these
> changes were submitted somewhere for review before the commit...
>
> -- Hiroki
Hi Hiroki,
The change was a temporary quick-fix to get the PR viewer working again.
I am not intimately familiar with the doc build system, so wasn't sure
about the best way to add the new subdirectories; but your way looks a
lot cleaner to me.
The script itself was made available some time ago on freebsd-www, so I
considered it reviewed; I just didn't foresee the need for the other
changes.
Shaun
--
Shaun Amott // PGP: 0x6B387A9A
"A foolish consistency is the hobgoblin
of little minds." - Ralph Waldo Emerson
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAk4oIbIACgkQkmhdCGs4eppF3ACgj6PlkO5+G4sSeQpQrSZprgNh
cF8AoOa6NBYvlxYYHxSFET32hB9TuxGR
=3zWx
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110721125514.GA57642>