Date: Thu, 07 Dec 2000 10:50:13 -0800 (PST) From: John Baldwin <jhb@FreeBSD.ORG> To: Archie Cobbs <archie@dellroad.org> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ichsmb ichsmb.c ichsmb_var.h Message-ID: <XFMail.001207105013.jhb@FreeBSD.org> In-Reply-To: <200012071836.eB7Ia0g20591@curve.dellroad.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07-Dec-00 Archie Cobbs wrote: > John Baldwin writes: >> > Mind if I ask why? Sorry if I'm missing something obvious. >> >> I'm just pushing the panic button a little. We aren't really yet ready as >> it >> were for locking drivers yet is all, so I just want to have a look-see over >> the >> first few that go in to make sure they will server as good examples to >> everyone >> else. > > Sounds prudent. So.. how'd I do?? :-) Looks ok at first glance. :) Was splhigh() protecting anything other than the ichsmb softc? Also, which SMBus methods are you referring to in this comment? + * + * This driver assumes that the generic SMBus code will ensure that + * at most one process at a time calls into the SMBus methods below. > -Archie -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001207105013.jhb>