Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 05 Feb 2009 18:55:53 +0100
From:      Niclas Zeising <niclas.zeising@gmail.com>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r188154 - head/sys/opencrypto
Message-ID:  <498B2829.9000608@gmail.com>
In-Reply-To: <200902051743.n15HhCMx033130@svn.freebsd.org>
References:  <200902051743.n15HhCMx033130@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote:
> Author: imp
> Date: Thu Feb  5 17:43:12 2009
> New Revision: 188154
> URL: http://svn.freebsd.org/changeset/base/188154
> 
> Log:
>   Fix return type for detach routine (should be int)
>   Fix first parameter for identify routine (should be driver_t *)
> 
> Modified:
>   head/sys/opencrypto/cryptosoft.c
> 
> Modified: head/sys/opencrypto/cryptosoft.c
> ==============================================================================
> --- head/sys/opencrypto/cryptosoft.c	Thu Feb  5 15:09:42 2009	(r188153)
> +++ head/sys/opencrypto/cryptosoft.c	Thu Feb  5 17:43:12 2009	(r188154)
> @@ -986,7 +986,7 @@ done:
>  }
>  
>  static void
> -swcr_identify(device_t *dev, device_t parent)
> +swcr_identify(driver_t *drv, device_t parent)
                            ^^^

Was this name change intentional?

>  {
>  	/* NB: order 10 is so we get attached after h/w devices */
>  	if (device_find_child(parent, "cryptosoft", -1) == NULL &&
> @@ -1040,12 +1040,13 @@ swcr_attach(device_t dev)
>  	return 0;
>  }
>  
> -static void
> +static int
>  swcr_detach(device_t dev)
>  {
>  	crypto_unregister_all(swcr_id);
>  	if (swcr_sessions != NULL)
>  		free(swcr_sessions, M_CRYPTO_DATA);
> +	return 0;
>  }
>  
>  static device_method_t swcr_methods[] = {

Regards!
//Niclas




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?498B2829.9000608>