Date: Thu, 9 Oct 2003 08:01:22 -0600 From: Greg Lewis <glewis@eyesbeyond.com> To: Munehiro Matsuda <haro@kgt.co.jp> Cc: freebsd-java@freebsd.org Subject: Re: jdk14 patches Message-ID: <20031009140122.GA95791@misty.eyesbeyond.com> In-Reply-To: <20031009.182515.74753005.haro@kgt.co.jp> References: <20031009005113.GA50130@misty.eyesbeyond.com> <20031009.182515.74753005.haro@kgt.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Haro-san, On Thu, Oct 09, 2003 at 06:25:15PM +0900, Munehiro Matsuda wrote: > Good work, as always. :-) > > But grancing through your patches, I'm not sure I like the > following part, which tries to work around the '_LITTLE_ENDIAN' > problem. This change may hide other errors, that may cause > more trouble in the future. I agree. I don't intend to commit this patch to the project repository, but it was the simplest patch to get people going with the port. > I use the following patch myself. I don't like my patch, neither. ;-) > But better show errors, than hide them away. > > ---8<------8<------8<--- patch-zharo-common::Defs-bsd.gmk ---8<------8<---- > --- ../../j2se/make/common/Defs-bsd.gmk.org Wed Oct 8 09:31:35 2003 > +++ ../../j2se/make/common/Defs-bsd.gmk Mon Oct 6 20:33:00 2003 > @@ -277,7 +277,13 @@ > CXXFLAGS_DBG = -g > > CPPFLAGS_COMMON = -D$(ARCH) -DARCH='"$(ARCH)"' $(VERSION_DEFINES) \ > - -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D_LITTLE_ENDIAN > + -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE > + > +ifeq ($(TRUE_PLATFORM), FreeBSD) > +CPPFLAGS_COMMON += -D_LITTLE_ENDIAN=1234 > +else > +CPPFLAGS_COMMON += -D_LITTLE_ENDIAN > +endif > > ifeq ($(ARCH_DATA_MODEL), 64) > CPPFLAGS_COMMON += -D_LP64=1 I have a different patch I was intending to commit. It removes the setting of -D_LITTLE_ENDIAN at all and uses <endian.h> to replace its usage in the appropriate files. That is what ended up being done in 1.3, so I was just going to do the same in 1.4 (Alexey asked me to hold off until after patchset 4 though). Comments? -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031009140122.GA95791>