Date: Mon, 11 Mar 1996 08:24:51 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, wosch@cs.tu-berlin.de Cc: current@FreeBSD.org Subject: Re: *.mk wishes Message-ID: <199603102124.IAA15692@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>20 programs which use mmap(2) >3 (gnu) programs with C macro HAVE_MMAP or HAVE_WORKING_MMAP I only found 2 :-) (gdb and groff). They are apparently too old and/or complicated to use autoconf and haven't been configured quite right for FreeBSD (unless mmap was avoided on purpose). >5 programs with PROT_WRITE >21 mmap calls with uncasted 'NULL' argument >Ok, we don't need a variable in sys.mk for 3 programs only. We should >fix the cast ... newfs/mkfs.c passes an uncast 0 for a pointer and an uncast 0 for an off_t. rpc.statd passes an uncast NULL for a pointer and an uncast 0 for an off_t. I would't worry about fixing this. There must be a prototype in scope for the uncast 0 for an off_t to work, and it isn't a bug to omit the casts iff there is a prototype in scope. Just fix the configuration. Do we have a working mmap? :-) Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199603102124.IAA15692>