Date: Sun, 25 Jan 2004 01:17:54 +0700 (KRAT) From: Eugene Grosbein <eugen@grosbein.pp.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/61846: [PATCH] cosmetic off-by-one error in ipfw2 leads to SIGSEGV Message-ID: <200401241817.i0OIHsFE010901@grosbein.pp.ru> Resent-Message-ID: <200401241820.i0OIK95k014626@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 61846
>Category: bin
>Synopsis: [PATCH] cosmetic off-by-one error in ipfw2 leads to SIGSEGV
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 24 10:20:08 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Eugene Grosbein
>Release: FreeBSD 4.9-STABLE i386
>Organization:
Svyaz Service JSC
>Environment:
System: FreeBSD grosbein.pp.ru 4.9-STABLE FreeBSD 4.9-STABLE #8: Sun Dec 14 20:25:57 KRAT 2003 eu@grosbein.pp.ru:/usr/local/obj/usr/local/src/sys/DADV i386
>Description:
ipfw2 can segfault when is run with incorrect parameters
>How-To-Repeat:
ipfw pipe 1 config 1Kbyte/s
>Fix:
--- ipfw2.c.orig Sun Jan 25 01:12:53 2004
+++ ipfw2.c Sun Jan 25 01:14:16 2004
@@ -2413,7 +2413,7 @@
break;
default:
- errx(EX_DATAERR, "unrecognised option ``%s''", *av);
+ errx(EX_DATAERR, "unrecognised option ``%s''", av[-1]);
}
}
if (do_pipe == 1) {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401241817.i0OIHsFE010901>