Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 05 Dec 2024 00:52:16 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 272787] Add asmc support for MacBookPro10,1, MacMini6,2, and MacBookPro8,3
Message-ID:  <bug-272787-227-H9L2xN70i1@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-272787-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-272787-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272787

--- Comment #6 from Jason W. Bacon <jwb@freebsd.org> ---
(In reply to ed crowe from comment #4)

Thanks, updating to=20

        case ASMC_ALSL_INT2A:
                /*
                 * This suppresses console and log messages for the ambient
                 * light sensor for models known to generate this interrupt.
                 */
                if (strcmp(sc->sc_model->smc_model, "MacBookPro5,5") =3D=3D=
 0 ||
                    strcmp(sc->sc_model->smc_model, "MacBookPro6,2") =3D=3D=
 0 ||
                    strcmp(sc->sc_model->smc_model, "MacBookPro8,3") =3D=3D=
 0)
                        break;

has silenced the log messages.  I'll give some thought to a pull request, b=
ut
I'd like to improve on the rest of the patch first.  Most of the values of
dev.asmc look reasonable, but I don't even know what some of them represent=
, or
if they're relevant to this model, e.g.

dev.asmc.0.temp.TCTD: 0
dev.asmc.0.fan.1.safespeed: -1
dev.asmc.0.light.control: 0

I'll see if I can dig up some info on this.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-272787-227-H9L2xN70i1>