Date: Wed, 27 Jun 2007 11:50:15 +0100 From: Doug Rabson <dfr@rabson.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: Philippe Pegon <Philippe.Pegon@crc.u-strasbg.fr>, current@FreeBSD.org Subject: Re: nfs on zfs panic Message-ID: <0BA830D6-D3EA-4E07-A004-CD22DC473901@rabson.org> In-Reply-To: <20070627101249.GA1128@garage.freebsd.pl> References: <46813AF4.4020004@crc.u-strasbg.fr> <C465AD69-BA88-4B02-90FA-AF8A70742F3B@rabson.org> <20070627070618.GC21749@garage.freebsd.pl> <200706270837.28175.dfr@rabson.org> <20070627101249.GA1128@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 Jun 2007, at 11:12, Pawel Jakub Dawidek wrote: > On Wed, Jun 27, 2007 at 08:37:27AM +0100, Doug Rabson wrote: >> On Wednesday 27 June 2007, Pawel Jakub Dawidek wrote: >>> On Tue, Jun 26, 2007 at 06:10:44PM +0100, Doug Rabson wrote: >>>> It looks like nvp is NULL at the point where it crashed. Looking at >>>> the zfs code, zfs_vget always returns zero, even if it failed to >>>> find a vnode which matches the given 'inode' number. Try changing >>>> the return statement in zfs_vget from 'return (0)' to 'return >>>> (err)'. >>> >>> Your analysis is correct, can you commit this? >> >> I tried to commit it but got the 'need Approved by: re' message. >> Do you >> have blanket re approval for this stuff? > > Nope. Could you ask re@ for approval? If you don't have time, I'll > handle this later. I'll sort things out with re@.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0BA830D6-D3EA-4E07-A004-CD22DC473901>