Date: Fri, 01 May 2009 08:57:24 -0700 From: Sam Leffler <sam@freebsd.org> To: Bruce Simpson <bms@incunabulum.net> Cc: Dennis Melentyev <dennis.melentyev@gmail.com>, stable@freebsd.org, "current@freebsd.org" <current@freebsd.org>, Maxim Sobolev <sobomax@sippysoft.com> Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 Message-ID: <49FB1BE4.20502@freebsd.org> In-Reply-To: <49FB1A3F.3000809@freebsd.org> References: <49E6DB25.2010601@sippysoft.com> <b84edfa10904160238u7a94e4aw4f60372a6b99f2a2@mail.gmail.com> <49E6FF8F.4070403@sippysoft.com> <b84edfa10904160505s45bcee01n3e516a00d1e4dffe@mail.gmail.com> <49ED6AD2.4010006@incunabulum.net> <49EDDD51.9040608@freebsd.org> <49FAF3F5.5070609@incunabulum.net> <49FB1A3F.3000809@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler wrote:
> Bruce Simpson wrote:
>> Hi,
>>
>> Can you please try this patch?
>> I can't commit it until STABLE is unfrozen after 7.2-RELEASE is cut.
>>
>> Sam Leffler wrote:
>>> Bruce Simpson wrote:
>>>
>>>> Hi,
>>>>
>>>> Looks like I'm late to the party. I was responsible for committing
>>>> these
>>>> ath(4) changes to RELENG_7.
>>>> I can't remember if I tested the kernel compile without the
>>>> AH_SUPPORT_AR5416 option or not, I have been so incredibly busy.
>>>> ...
>>> ru had a change to fix this but decided not to; can't say why.
>>> Otherwise there is a better way to fix this which I alluded to in
>>> previous mail--use the config-generated #define that is generated for
>>> the "ath_hal" device.
> Do not modify ah_desc.h like you've done. Add this to conf/options
>
> ATH_HAL opt_ah.h
>
> and use that to enable AH_SUPPORT_AR5416.
>
> Also changes must go in head first.
To clarify the first comment: you've made it impossible to build code
w/o the extended format descriptor; this is what I find unacceptable.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49FB1BE4.20502>