Date: Thu, 12 Nov 2009 02:22:03 +0100 From: Attilio Rao <attilio@freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r199209 - head/sys/kern Message-ID: <3bbf2fe10911111722j436d8b82oa66fb5cb581c7205@mail.gmail.com> In-Reply-To: <200911120052.nAC0qEjC012881@svn.freebsd.org> References: <200911120052.nAC0qEjC012881@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/11/12 Attilio Rao <attilio@freebsd.org>: > Author: attilio > Date: Thu Nov 12 00:52:14 2009 > New Revision: 199209 > URL: http://svn.freebsd.org/changeset/base/199209 > > Log: > The building the dev nameunit string, in devclass_add_device() is based > on the assumption that the unit linked with the device is invariant but > that can change when calling devclass_alloc_unit() (because -1 is passed > or, more simply, because the unit choosen is beyond the table limits). > This results in a completely bogus string building. > > Fix this by reserving the necessary room for all the possible characters > printable by a positive integer (we do not allow for negative unit > number). > > Reported by: Sandvine Incorporated > Reviewed by: emaste Sorry, forgot to add: reviewed by: jhb, imp Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10911111722j436d8b82oa66fb5cb581c7205>