Date: Fri, 31 Oct 2003 18:37:14 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Peter Wemm <peter@FreeBSD.org> Subject: Re: cvs commit: src/sys/sys cdefs.h Message-ID: <20031031163713.GA30874@sunbay.com> In-Reply-To: <20031101002134.Y1748@gamplex.bde.org> References: <200310310542.h9V5gr8v023991@repoman.freebsd.org> <20031031230028.K1418@gamplex.bde.org> <20031031123129.GB777@sunbay.com> <20031101002134.Y1748@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Nov 01, 2003 at 12:34:51AM +1100, Bruce Evans wrote:
> On Fri, 31 Oct 2003, Ruslan Ermilov wrote:
>=20
> > On Fri, Oct 31, 2003 at 11:15:40PM +1100, Bruce Evans wrote:
> > > ...
> > > While it is good to check for warnings in system headers, this should=
n't
> > > be forced on everyone. Applications that want to check for the non-e=
rror
> > > of using undefined identifiers in cpp expressions shouldn't enable
> > > warnings in system headers unless they want to get warnings if the he=
aders
> > > use this standard C feature (and other warnings). Applications in th=
e src
> > > tree won't do this.
> > >
> > What's the underlying issue here? I always thought that FreeBSD is dif=
ferent
> > from GNU is this respect -- we treat our system as the whole, so the pi=
ece
> > of code is as clean as its worst part; that may be a system header, too.
> > Remember the issue? Old versions of buildworld used -nostdinc hack and
> > -I... to ${WORLDTMP}/usr/include, and it caused WARNS to be generating
> > different warnings while in buildworld compared to a normal (no -nostdi=
nc)
> > build. I'm against reverting the toplev.c change, but it also made the
> > sys.mk part redundant, so the latter may be reverted now.
>=20
> The system shouldn't have to satisfy cleanness standards of applications
> that are not maintained by FreeBSD, especially when those standards
> are bogus (e.g., compiling cleanly with -Wundef). Hopefull all the
> important corner cases in the system headers are tested by buildworld
> so that we don't need to enlist the application maintainers to find bugs
> in system headers.
>=20
Now that buildworld and normal builds behave the same, I tend to agree.
Count this as "no objection" to revert this.
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
--45Z9DzgjV8m4Oswq
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQE/oo+5Ukv4P6juNwoRAmJvAJ9Gt4svabjgqY37Y0BQRuDYsYA9rwCfc0Rj
VKsKN9UNp8c2C0+8EgOddnQ=
=r+if
-----END PGP SIGNATURE-----
--45Z9DzgjV8m4Oswq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031031163713.GA30874>