Date: Fri, 5 Jan 2001 01:07:17 +0000 (GMT) From: Nick Hibma <n_hibma@qubesoft.com> To: Peter Wemm <peter@netplex.com.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern makedevops.pl makeobjops.pl Message-ID: <Pine.BSF.4.10.10101050106450.77105-100000@bluebottle> In-Reply-To: <200101041808.f04I8Jq10348@mobile.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ok, I will separate them next time. Nick On Thu, 4 Jan 2001, Peter Wemm wrote: > Nick Hibma wrote: > > n_hibma 2001/01/04 05:41:24 PST > > > > Modified files: > > sys/kern makedevops.pl makeobjops.pl > > Log: > > Fix a bug in both scripts: HEADER sections were not emitted to the header > > file. > > > > While there fix the layout of function headers (noticable in long headers) > > > > Fix up some style nits. It's Perl and should be written in that style. > > > > Revision Changes Path > > 1.14 +9 -10 src/sys/kern/makedevops.pl > > 1.2 +319 -326 src/sys/kern/makeobjops.pl > > It is a bug to commit functional changes and reformatting changes in the > same commit. Like this, it is practically impossible to see the bug fix you > made as it is buried in the noise of the reformatting change. > > (I dont mean to pick on you specifically, others have been doing this > recently too) > > Cheers, > -Peter > -- > Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > "All of this is for nothing if we don't go to the stars" - JMS/B5 > > > -- Work: n_hibma@qubesoft.com Personal: n_hibma@webweaving.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.10101050106450.77105-100000>