Date: Thu, 08 Jan 2009 20:18:02 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: hselasky@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 155748 for review Message-ID: <20090108.201802.-1782466862.imp@bsdimp.com> In-Reply-To: <200901081839.27124.hselasky@freebsd.org> References: <200901071009.n07A9jrs056953@repoman.freebsd.org> <20090108.102311.1541746851.imp@bsdimp.com> <200901081839.27124.hselasky@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200901081839.27124.hselasky@freebsd.org>
Hans Petter Selasky <hselasky@freebsd.org> writes:
: On Thursday 08 January 2009, M. Warner Losh wrote:
: > In message: <200901071009.n07A9jrs056953@repoman.freebsd.org>
: >
: > Hans Petter Selasky <hselasky@freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=155748
: > :
: > : Change 155748 by hselasky@hselasky_laptop001 on 2009/01/07 10:09:35
: > :
: > :
: > : Umass module quirk from Alexander Best
: > : to support Meizu Electronics MiniPlayer.
: > :
: > : Affected files ...
: > :
: > : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit
: > :
: > : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21
: > : (text+ko) ==== ====
: > : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21
: > : (text+ko) ====
: >
: > Why are these generated files committed to the tree? We did a lot of
: > work to make usbdevs generated files not need to be committed to the
: > tree and this breaks that...
: >
: > Warner
:
: Because they are not automatically generated any more.
They are automatically generated.
You mean that they are no longer automatically generated as part of
the build? I'm wondering why not? We went to a lot of trouble to dig
out of the problems that causes, and I'd hate to see us go back to the
bad old days...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090108.201802.-1782466862.imp>