Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Mar 1999 10:36:21 -0700
From:      Nate Williams <nate@mt.sri.com>
To:        John Polstra <jdp@polstra.com>
Cc:        green@unixhelp.org, current@FreeBSD.ORG
Subject:   Re: callout changes nit
Message-ID:  <199903061736.KAA24445@mt.sri.com>
In-Reply-To: <199903061641.IAA44512@vashon.polstra.com>
References:  <Pine.BSF.4.05.9903061057250.11342-100000@janus.syracuse.net> <199903061641.IAA44512@vashon.polstra.com>

next in thread | previous in thread | raw e-mail | index | archive | help
> > I make a habit of checking out any interesting kernel changes in full, and one
> > thing I found in the recent diff by Mr. Wollman for kern_timeout.c is:
> > 
> > +void
> > +callout_init(c)
> > +       struct  callout *c;
> > +{
> > +       bzero(c, sizeof c);
> >  }
> > 
> > That doesn't look correct, does it?
> 
> Agreed.  I think it should be "sizeof *c".

Ahh, I see.  I think it should say

       bzero(c, sizeof(struct callout));

To avoid the compiler using the size of the pointers et. al.


Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903061736.KAA24445>