Date: Sun, 9 Jan 2005 05:25:02 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netipx spx_usrreq.c Message-ID: <200501090525.j095P2hZ042570@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2005-01-09 05:25:02 UTC
FreeBSD src repository
Modified files:
sys/netipx spx_usrreq.c
Log:
Clean up return handling for a number of SPX-related routines that
were derived from more complex TCP versions of the same:
- spx_close(), spx_disconnect(), spx_drop(), and spx_usrclosed() all
always free's the spxpcb invalidating the argument, so a return
value is not required to indicate if it has.
- Annotate that the cb arguments to each of these functions is
invalidated via a comment.
- When tearing down a pcb due to sonewconn() having failed, mark the
cb as NULL; later, when deciding whether to store trace information
due to SO_DEBUG, check that cb is not NULL before dereferencing or
a NULL pointer dereference may occur.
MFC after: 3 weeks
Revision Changes Path
1.60 +29 -22 src/sys/netipx/spx_usrreq.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501090525.j095P2hZ042570>