Date: Fri, 15 Jul 2005 10:42:09 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Sean Winn <sean@gothic.net.au> Cc: freebsd-bugs@freebsd.org Subject: Re: bin/83468: imported OpenBSD dhclient handles hostnames differently to ISC DHCP 3 - come through as hex Message-ID: <20050715174209.GB337@odin.ac.hmc.edu> In-Reply-To: <200507142350.j6ENoLjY089474@freefall.freebsd.org> References: <200507142350.j6ENoLjY089474@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dTy3Mrz/UPE2dbVg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
It seem likely the proposed patch breaks options that should be in hex
(after all, 0x00 is perfectly valid as the last character in a MAC
addrss or similar.) Please try the following change instead.
Thanks,
Brooks
Index: tables.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /usr/cvs/src/sbin/dhclient/tables.c,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 tables.c
--- tables.c 7 Jun 2005 04:05:09 -0000 1.1.1.1
+++ tables.c 15 Jul 2005 17:35:49 -0000
@@ -74,7 +74,7 @@ struct option dhcp_options[256] =3D {
{ "lpr-servers", "IA", &dhcp_universe, 9 },
{ "impress-servers", "IA", &dhcp_universe, 10 },
{ "resource-location-servers", "IA", &dhcp_universe, 11 },
- { "host-name", "X", &dhcp_universe, 12 },
+ { "host-name", "t", &dhcp_universe, 12 },
{ "boot-size", "S", &dhcp_universe, 13 },
{ "merit-dump", "t", &dhcp_universe, 14 },
{ "domain-name", "t", &dhcp_universe, 15 },
--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
--dTy3Mrz/UPE2dbVg
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFC1/VwXY6L6fI4GtQRAihDAJ9PXpQpK186rtR27VXqYdeuRl3gqACgpIh+
wz0txvORnMTZ5H5xJGuNL0w=
=IrsX
-----END PGP SIGNATURE-----
--dTy3Mrz/UPE2dbVg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050715174209.GB337>