Date: Fri, 1 May 2026 11:10:15 +0200 From: Daniel Engberg <diizzy@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: e70dc4653b10 - main - devel/vectorscan: Add vectorscan 5.4.12 Message-ID: <3b96bcca-8a2f-4ee4-b4f9-0caf445a73ab@FreeBSD.org> In-Reply-To: <05b140a6-099f-4687-bc4c-0168182e0d79@FreeBSD.org> References: <69f462a6.3e5bc.7d4f833e@gitrepo.freebsd.org> <05b140a6-099f-4687-bc4c-0168182e0d79@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2026-05-01 11:04, Daniel Engberg wrote: > On 2026-05-01 10:21, Xin LI wrote: >> The branch main has been updated by delphij: >> >> URL:https://cgit.FreeBSD.org/ports/commit/?id=e70dc4653b10f5ea53da0a2b6ed286fe61555e22 >> >> commit e70dc4653b10f5ea53da0a2b6ed286fe61555e22 >> Author: Xin LI<delphij@FreeBSD.org> >> AuthorDate: 2025-10-30 05:25:07 +0000 >> Commit: Xin LI<delphij@FreeBSD.org> >> CommitDate: 2026-05-01 08:20:55 +0000 >> >> devel/vectorscan: Add vectorscan 5.4.12 >> >> Portable fork of high-performance multiple regex matching library >> --- >> devel/Makefile | 1 + >> devel/vectorscan/Makefile | 66 ++++++++++++++++++++++ >> devel/vectorscan/distinfo | 5 ++ >> .../vectorscan/files/patch-cmake_build__wrapper.sh | 27 +++++++++ >> devel/vectorscan/pkg-descr | 12 ++++ >> devel/vectorscan/pkg-plist | 14 +++++ >> 6 files changed, 125 insertions(+) >> >> diff --git a/devel/Makefile b/devel/Makefile >> index 1b3717183446..aeda92049c62 100644 >> --- a/devel/Makefile >> +++ b/devel/Makefile >> @@ -8698,6 +8698,7 @@ >> SUBDIR += vc-intrinsics >> SUBDIR += vcglib >> SUBDIR += vdf >> + SUBDIR += vectorscan >> SUBDIR += venom >> SUBDIR += vera++ >> SUBDIR += vexcl >> diff --git a/devel/vectorscan/Makefile b/devel/vectorscan/Makefile >> new file mode 100644 >> index 000000000000..dd8bc0cea64d >> --- /dev/null > Hi, > > Please use DISTVERSION instead of PORTVERSION > https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions > Please fix ordering, See Example 7 CMAKE_ARGS and CFLAGS are also > oddly placed, portfmt will help to improve port layout but it does > have some odd suggestions at times. Port doesn't respect CFLAGS (-O3 > and CPUTYPE) > https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags > https://codeberg.org/gentoo/gentoo/src/branch/master/dev-libs/vectorscan/vectorscan-5.4.12.ebuild > might be useful Do not set flags such as NATIVE, it breaks on no x86 > arches and port should rely on CPUTYPE as mentioned in PR > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294399 and we've > been actively migrating away from that. > > Preferably we should unbundle boost > https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices > > For consistency with the rest of the tree there should be a toggle for > static library not shared, > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n480 > > Best regards, Daniel > Hi, Hit enter too soon, port also uses -std=c++17 while Makefile sets USES= compiler:c++11-lib Best regards, Daniel [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">On 2026-05-01 11:04, Daniel Engberg wrote:<br> </div> <blockquote type="cite" cite="mid:05b140a6-099f-4687-bc4c-0168182e0d79@FreeBSD.org"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <div class="moz-cite-prefix">On 2026-05-01 10:21, Xin LI wrote:<br> </div> <blockquote type="cite" cite="mid:69f462a6.3e5bc.7d4f833e@gitrepo.freebsd.org"> <pre wrap="" class="moz-quote-pre">The branch main has been updated by delphij: URL: <a class="moz-txt-link-freetext" href="https://cgit.FreeBSD.org/ports/commit/?id=e70dc4653b10f5ea53da0a2b6ed286fe61555e22" moz-do-not-send="true">https://cgit.FreeBSD.org/ports/commit/?id=e70dc4653b10f5ea53da0a2b6ed286fe61555e22</a>; commit e70dc4653b10f5ea53da0a2b6ed286fe61555e22 Author: Xin LI <a class="moz-txt-link-rfc2396E" href="mailto:delphij@FreeBSD.org" moz-do-not-send="true"><delphij@FreeBSD.org></a> AuthorDate: 2025-10-30 05:25:07 +0000 Commit: Xin LI <a class="moz-txt-link-rfc2396E" href="mailto:delphij@FreeBSD.org" moz-do-not-send="true"><delphij@FreeBSD.org></a> CommitDate: 2026-05-01 08:20:55 +0000 devel/vectorscan: Add vectorscan 5.4.12 Portable fork of high-performance multiple regex matching library --- devel/Makefile | 1 + devel/vectorscan/Makefile | 66 ++++++++++++++++++++++ devel/vectorscan/distinfo | 5 ++ .../vectorscan/files/patch-cmake_build__wrapper.sh | 27 +++++++++ devel/vectorscan/pkg-descr | 12 ++++ devel/vectorscan/pkg-plist | 14 +++++ 6 files changed, 125 insertions(+) diff --git a/devel/Makefile b/devel/Makefile index 1b3717183446..aeda92049c62 100644 --- a/devel/Makefile +++ b/devel/Makefile @@ -8698,6 +8698,7 @@ SUBDIR += vc-intrinsics SUBDIR += vcglib SUBDIR += vdf + SUBDIR += vectorscan SUBDIR += venom SUBDIR += vera++ SUBDIR += vexcl diff --git a/devel/vectorscan/Makefile b/devel/vectorscan/Makefile new file mode 100644 index 000000000000..dd8bc0cea64d --- /dev/null </pre> </blockquote> <span style="white-space: pre-wrap">Hi,</span> <p><span style="white-space: pre-wrap">Please use DISTVERSION instead of PORTVERSION <a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile" moz-do-not-send="true">https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile</a>; <a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions" moz-do-not-send="true">https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions</a>; Please fix ordering, See Example 7 CMAKE_ARGS and CFLAGS are also oddly placed, portfmt will help to improve port layout but it does have some odd suggestions at times. Port doesn't respect CFLAGS (-O3 and CPUTYPE) <a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags" moz-do-not-send="true">https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags</a>; <a class="moz-txt-link-freetext" href="https://codeberg.org/gentoo/gentoo/src/branch/master/dev-libs/vectorscan/vectorscan-5.4.12.ebuild" moz-do-not-send="true">https://codeberg.org/gentoo/gentoo/src/branch/master/dev-libs/vectorscan/vectorscan-5.4.12.ebuild</a>; might be useful Do not set flags such as NATIVE, it breaks on no x86 arches and port should rely on CPUTYPE as mentioned in PR <a class="moz-txt-link-freetext" href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294399" moz-do-not-send="true">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294399</a>; and we've been actively migrating away from that.</span></p> <p>Preferably we should unbundle boost<br> <a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices" moz-do-not-send="true">https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices</a><br>; <br> For consistency with the rest of the tree there should be a toggle for static library not shared,<br> <a class="moz-txt-link-freetext" href="https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n480" moz-do-not-send="true">https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n480</a><span style="white-space: pre-wrap"></span></p> <p><span style="white-space: pre-wrap">Best regards, Daniel </span></p> </blockquote> Hi,<br> <br> Hit enter too soon, port also uses -std=c++17 while Makefile sets USES= compiler:c++11-lib<br> <br> Best regards,<br> Daniel </body> </html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3b96bcca-8a2f-4ee4-b4f9-0caf445a73ab>