Date: Mon, 28 Jul 2008 12:27:15 +0200 From: Roman Divacky <rdivacky@freebsd.org> To: Chagin Dmitry <chagin.dmitry@gmail.com> Cc: Alexander Leidinger <Alexander@leidinger.net>, freebsd-emulation@freebsd.org Subject: Re: kern/117010: [linux] linux_getdents() get somethinng like buffer overflow Message-ID: <20080728102715.GA78842@freebsd.org> In-Reply-To: <alpine.BSF.1.10.0807281300060.1453@ora.chd.net> References: <200807250700.m6P70FSF036132@freefall.freebsd.org> <20080726091045.4c617dc7@deskjail> <alpine.BSF.1.10.0807271958020.3912@ora.chd.net> <20080728085403.58063b2gbchdjtic@webmail.leidinger.net> <alpine.BSF.1.10.0807281300060.1453@ora.chd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[snip of technical discussion] while I agree with the attitude that it should be fixed properly, we are in a situation where a simple patch fixes a problem. and the fix is correct. I think we should just commit Dmitry's patch and then talk about how to change linux_getdents() further. I looked at the Linux code and the alignment is really +2 for 32bit and +1 for 64 bit as Dmitry's patch does. do you guys agree that fixing the problem the simplest/fastest way now and then changing other things is the correct way? roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080728102715.GA78842>