Date: Fri, 5 Mar 2004 17:47:14 +0200 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Andrey Chernov <ache@nagual.pp.ru>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, "David O'Brien" <obrien@FreeBSD.ORG> Subject: Re: cvs commit: src/gnu/usr.bin/binutils Makefile.inc0 Message-ID: <20040305154714.GA31834@ip.net.ua> In-Reply-To: <20040305152917.GA71254@nagual.pp.ru> References: <200403050147.i251l39I006593@repoman.freebsd.org> <200403042036.i24KaIeq025097@repoman.freebsd.org> <20040305141012.GA10639@ip.net.ua> <20040305143708.GA70192@nagual.pp.ru> <20040305152247.GB11063@ip.net.ua> <20040305152917.GA71254@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 05, 2004 at 06:29:18PM +0300, Andrey Chernov wrote: > On Fri, Mar 05, 2004 at 05:22:47PM +0200, Ruslan Ermilov wrote: > > > > But it's added last, by the special version of <bsd.prog.mk> from > > src/tools/build/mk/. >=20 > Why? This way you can't be sure some progam's -I will damage things. > Just add it first instead. >=20 Because what makefiles specifies explicitly (like after your change does for -I/usr/include in the case where cross-tools are built) should be preferred. (Consider an unlikely but still possible case when a tool has its own "getopt.h" with completely different contents not related to getopt(3).) As such, bits from ${WORLDTMP} can only be used as a fallback. I know wonder what happens when you upgrade from RELENG_4 and tools are built in a host environment without /usr/include/gnu. All they use /usr/include/regex.h now where they previously used /usr/include/gnuregex.h. Is this correct? Dangerous? > > David, remove the damn header please. >=20 > Already asked many times... >=20 Perhaps that's the problem? ;) Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --azLHFNyN32YCQGCU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFASKECUkv4P6juNwoRAjUnAJ4ikuF4w0uCuvUa5r2acYYWhUxCWwCeOYJg Jni0o9vrPEsliL4x2dP7DaQ= =yA8p -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040305154714.GA31834>