Date: Wed, 5 Jun 2013 09:50:03 +0100 From: Chris Rees <utisoft@gmail.com> To: David Schultz <das@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r251404 - in head/lib/msun: . src Message-ID: <CADLo83-7dRrGTqDGp5%2Bg8JsJknwS1VZN-d4-MDPHcYxyN%2B1KvA@mail.gmail.com> In-Reply-To: <20130605081301.GA42959@zim.MIT.EDU> References: <201306050533.r555X2dQ047208@svn.freebsd.org> <CADLo83-8Q-uSD3JxiiGG4ZEfrYuR5sGc4%2BMaFNr4Q00B=TWd-w@mail.gmail.com> <20130605081301.GA42959@zim.MIT.EDU>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5 Jun 2013 09:13, "David Schultz" <das@freebsd.org> wrote: > > On Wed, Jun 05, 2013, Chris Rees wrote: > > On 5 Jun 2013 06:33, "David Schultz" <das@freebsd.org> wrote: > > > > > > Author: das > > > Date: Wed Jun 5 05:33:01 2013 > > > New Revision: 251404 > > > URL: http://svnweb.freebsd.org/changeset/base/251404 > > > > > > Log: > > > Style fixes. > > > > > > Submitted by: bde > > > > > > Modified: > > > head/lib/msun/Makefile > > > head/lib/msun/src/catrig.c > > > head/lib/msun/src/catrigf.c > > > head/lib/msun/src/e_log2.c > > > > > > Modified: head/lib/msun/Makefile > > > > > ============================================================================== > > > --- head/lib/msun/Makefile Wed Jun 5 01:22:59 2013 (r251403) > > > +++ head/lib/msun/Makefile Wed Jun 5 05:33:01 2013 (r251404) > > > @@ -21,6 +21,10 @@ ARCH_SUBDIR= ${MACHINE_CPUARCH} > > > .include "${ARCH_SUBDIR}/Makefile.inc" > > > > > > .PATH: ${.CURDIR}/${ARCH_SUBDIR} > > > +.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" > > > +.PATH: ${.CURDIR}/x86 > > > +CFLAGS+= -I${.CURDIR}/x86 > > > +.endif > > > > Since you're doing style fixes, it is worth noting that quoting strings in > > Makefiles is nearly always incorrect, and only works in our make because of > > an extension. > > Thanks -- I didn't know that, and apparently neither did whoever > wrote that line originally. But quoted strings are pervasive in > our makefiles; if there's a good reason to fix it, perhaps you > could go through and clean them up. :) I've thought about this, but really that kind of fix is repo churn. I'll see if I can find somewhere appropriate to document it; the only real harm is that people using other makes are constantly surprised when things like ifeq($(ARCH),"amd64") never match. Obviously this isn't directly our problem, but it's a nice portability concern. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-7dRrGTqDGp5%2Bg8JsJknwS1VZN-d4-MDPHcYxyN%2B1KvA>