Date: Mon, 9 Sep 1996 09:46:31 -0500 (CDT) From: Bob Willcox <bob@luke.pmr.com> To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/newsyslog newsyslog.c Message-ID: <199609091446.JAA05306@luke.pmr.com> In-Reply-To: <199609060636.XAA29293@freefall.freebsd.org> from "Jordan K. Hubbard" at "Sep 5, 96 11:36:13 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Jordan K. Hubbard wrote:
> jkh 96/09/05 23:36:12
>
> Modified: usr.sbin/newsyslog newsyslog.c
> Log:
> PR#2724 in NetBSD notes that newsyslog save log files even if the number
> of copies to save is zero. Incorporate suggested fix with some stylistic
> cleanup to make the resulting code more readable.
> Submitted-By: Kenneth Stailey <kstailey@dol-esa.gov>
>
> Revision Changes Path
> 1.6 +15 -6 src/usr.sbin/newsyslog/newsyslog.c
>
This change breaks newsyslog (on my system, anyway). Now, newsyslog
will never rename /var/log/maillog to /var/log/mailog.0 (for example).
The problem with the above change is that when numdays is -1 the
rename will be skipped. Unfortunately, numdays will *always* be
-1 at the termination of the while loop which precedes the changes.
:-(
Thanks,
--
Bob Willcox politics, n:
bob@luke.pmr.com A strife of interests masquerading as a contest of
Austin, TX principles. The conduct of public affairs for private
advantage. -- Ambrose Bierce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609091446.JAA05306>