Date: Fri, 1 Oct 2004 02:08:28 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: David Schultz <das@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_fork.c Message-ID: <20041001060828.GA997@green.homeunix.org> In-Reply-To: <200410010501.i9151US7086474@repoman.freebsd.org> References: <200410010501.i9151US7086474@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 01, 2004 at 05:01:29AM +0000, David Schultz wrote: > das 2004-10-01 05:01:29 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_fork.c > Log: > Avoid calling _PHOLD(p1) with p2's lock held, since _PHOLD() > may block to swap in p1. Instead, call _PHOLD earlier, at a > point where the only lock held happens to be p1's. Since you seem to have a handle on this: how hard do you think it would be to make all the [_]PHOLD() consumers able to handle an error return? Good job finding all these bugs! -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041001060828.GA997>