Date: Wed, 8 Oct 2014 13:10:19 -0700 From: Craig Rodrigues <rodrigc@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272649 - head/contrib/byacc Message-ID: <CAG=rPVcW=t=NDMzfusyZbL_=Eubtth3iFvf_bRo5rCjsMkjXCw@mail.gmail.com> In-Reply-To: <20141007223941.GT37670@ivaldir.etoilebsd.net> References: <201410061443.s96Eh2Jn022718@svn.freebsd.org> <20141006144924.GB37670@ivaldir.etoilebsd.net> <CAG=rPVfJFMa8VrSco6VnEW3Lf%2BM6gm0e4f4KSH=rvYEEs2EJog@mail.gmail.com> <20141007223941.GT37670@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin <bapt@freebsd.org> wrote: > On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: > > On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin <bapt@freebsd.org> > wrote: > > > > > > > > Why a direct commit instead of a proper import of 20141005 version? it > > > would > > > have imho been better, simpler and easier to maintain. > > > > > > > Because according to Thomas Dickey, he did not fix all > > the memory related problems in snapshot 20141005. Specifically there are > > still > > some issues not fixed when realloc() is called. > > I was going to wait for the next snapshot. > > However, I wanted to get that one fix into FreeBSD to fix the kyua tests, > > which have been failing under Jenkins. See: > > https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ > > (see runs #10 and #11). > > In that case I will import the new one which has the fix (do you confirm?) > According to http://invisible-island.net/byacc/CHANGES.html , the 2014-10-06 has a fix to address my concerns. However, this fix involves a lot of changes to the code, and I don't have time right now to audit everything. There have been a lot of changes to the byacc code in the past few days. The changes are good bugfixes, but I would recommend auditing everything beore importing the snapshot into FreeBSD. -- Craig
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVcW=t=NDMzfusyZbL_=Eubtth3iFvf_bRo5rCjsMkjXCw>