Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Feb 2017 16:59:13 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Wolfgang Zenker <wolfgang@lyxys.ka.sub.org>, freebsd-stable@FreeBSD.org
Subject:   Re: cyapa(4) and isl(4) no longer working on Acer C720
Message-ID:  <357d6dda-6137-7246-bd33-b7e5d8f20667@FreeBSD.org>
In-Reply-To: <2763492b-6c8c-08c1-17ca-13e1d94f5543@FreeBSD.org>
References:  <20170225131023.GA94128@lyxys.ka.sub.org> <2763492b-6c8c-08c1-17ca-13e1d94f5543@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 25/02/2017 16:46, Andriy Gapon wrote:
> On 25/02/2017 15:10, Wolfgang Zenker wrote:
>> Hi,
>>
>> I'm using FreeBSD 11 on a chromebook Acer C720. Because I normally
>> use a mouse I didn't catch the exact time when cyapa and isl stopped
>> working, but my guess is it was when chromebook_framework was introduced
>> and cyapa and isl were moved to using iic. 
>>
>> A manual page chromebook_platform(4) does not exist. Maybe the Acer is
>> sufficiently different from other chromebooks that chromebook_platform
>> does not work here. In that case I'm supposed to set device hints for
>> the isl and cyapa drivers where to find their iic resources, according
>> to https://github.com/freebsd/freebsd-base-graphics/commit/e2eab8e254154d36ebd6fde573f86e6472b75572
>> Unfortunately I have no idea where to find the information that would
>> be needed for this.
> The manual page actually exists... but only in the source code :-(
> share/man/man4/chromebook_platform.4
> Mea culpa.
> 
> You can look through this Linux source file to check for information that's
> relevant to your laptop:
> http://lxr.free-electrons.com/source/drivers/platform/chrome/chromeos_laptop.c

In fact, could you please try this trivial patch?

Index: sys/dev/chromebook_platform/chromebook_platform.c
===================================================================
--- sys/dev/chromebook_platform/chromebook_platform.c	(revision 314268)
+++ sys/dev/chromebook_platform/chromebook_platform.c	(working copy)
@@ -69,7 +69,7 @@
 	 * See
http://lxr.free-electrons.com/source/drivers/platform/chrome/chromeos_laptop.c
 	 */
 	controller = device_get_parent(bus);
-	if (strcmp(device_get_name(controller), "ig4iic") != 0)
+	if (strcmp(device_get_name(controller), "ig4iic_pci") != 0)
 		return;

 	for (i = 0; i < nitems(slaves); i++) {


Seems like I overlooked this when reviewing
https://svnweb.freebsd.org/base?view=revision&revision=310621

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?357d6dda-6137-7246-bd33-b7e5d8f20667>