Date: Thu, 30 Jun 2005 18:54:01 +0200 From: Andreas Tobler <toa@pop.agri.ch> To: Suleiman Souhlal <ssouhlal@FreeBSD.org> Cc: Current <freebsd-current@FreeBSD.org> Subject: Re: Acquiring lockmgr lock "ufs" with non-sleepable locks Message-ID: <42C423A9.3010603@pop.agri.ch> In-Reply-To: <59D725CA-BB01-48D5-A2D8-B2D4A9E6B177@FreeBSD.org> References: <7mhdg4q983.wl%kuriyama@imgsrc.co.jp> <C2C1A959-C36C-4A22-93E9-1744B20AC332@FreeBSD.org> <42C30E90.3030405@pop.agri.ch> <59D725CA-BB01-48D5-A2D8-B2D4A9E6B177@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello Suleiman, Suleiman Souhlal wrote: >>> This was introduced by my commit to take out the various kqueue >>> operations outside of ufs. It is because we are trying to lock the >>> vnode while holding the knlist mutex. I'll work on a fix on >>> wednesday, as I'll unfortunately be a bit busy until then. I hope >>> this won't cause you any inconvenience. >>> >> >> Is the below the same ? > > > Yes. > >> No, I did not try the follow-up patch yet. > > > The patch should fix it. I'll commit it as soon as I get approval. It did :) Thanks. The tail -f file works now. Though, I took the latest diff from your site (knlist_locking-20050629-2.diff) and had to add the thing below, you forgot a NULL in knlist_init. Regards, Andreas (p.s: patch hand edited) Index: src/sys/cam/scsi/scsi_target.c =================================================================== --- src/sys/cam/scsi/scsi_target.c (revision 187) +++ src/sys/cam/scsi/scsi_target.c (working copy) @@ -196,7 +196,7 @@ TAILQ_INIT(&softc->work_queue); TAILQ_INIT(&softc->abort_queue); TAILQ_INIT(&softc->user_ccb_queue); - knlist_init(&softc->read_select.si_note, &softc->mtx); + knlist_init(&softc->read_select.si_note, &softc->mtx, NULL, NULL, NULL); return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42C423A9.3010603>