Date: Wed, 2 Jun 2021 00:58:50 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org>, Alan Somers <asomers@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, Warner Losh <imp@bsdimp.com>, Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5a20c351ea45 - main - [skip ci] add a CODEOWNERS file Message-ID: <c42aa058-d084-e4a0-8472-2b0be0bb99da@FreeBSD.org> In-Reply-To: <YLXaB7Xt8Khy39MA@FreeBSD.org> References: <202105302249.14UMnbcl094541@gitrepo.freebsd.org> <CAPyFy2AHmrjdWyKnUMwEf5TnYub4j6um_rYHW6vwmvxR8g6LHw@mail.gmail.com> <CAOtMX2g7mHxQ3%2B0LWhwXLcDgrH0kedb2VrnPV9wmJMnA%2B6ZJDA@mail.gmail.com> <CAPyFy2DFUeEFGPD1tYcK48EcQkDd7DOBgmTwqXE5oj60qOsPKQ@mail.gmail.com> <CANCZdfoBa%2Bv8dBk6U3o2wW%2Bc-8w_fcHi85=9ZdiQfu1%2B=HAFdg@mail.gmail.com> <E778BD5D-1A73-42B0-93F1-871D7E0AC5EC@jrtc27.com> <CANCZdfqXb5pyFJ0cfCep1P73%2BC%2BR4hjXu5HkOF4ODjy7_AgGGw@mail.gmail.com> <0434E9D2-B0AA-4B5E-942A-A393A83DFFD1@freebsd.org> <CAOtMX2gDW=SvNF2EqrAs-N988pJtwy=GxJA=-kw2eFbrT5yHLw@mail.gmail.com> <YLXaB7Xt8Khy39MA@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/06/2021 01:56, Alexey Dokuchaev wrote: > On Mon, May 31, 2021 at 01:50:16PM -0600, Alan Somers wrote: >> On Mon, May 31, 2021 at 1:39 PM Jessica Clarke wrote: >>> ... >>> >>> A hypothetical .gitlab/CODEOWNERS would be checked in as a generated >>> file, if that was unclear. Otherwise I'm not sure I understand your >>> first point? >> There's no need to generate anything. Both github and gitlab support a >> CODEOWNERS file in the project's root. Let's just move it there. We can >> delete the old MAINTAINERS, too, once all of its entries have been >> converted. > Why delete *our* correctly named MAINTAINERS? Tomorrow GH or GL could > decide that "pwning" something bears unnecessary and potentially offending > connotations and break the scheme. I would argue that the list of MAINTAINERS file has basically nothing to do with building FreeBSD so it is currently misplaced. > They want CODEOWNERS now? Fine, all it takes is a simple script to parse > MAINTAINERS and generate CODEOWNERS file they want. Once/if this changes, > we'd easily adapt. CODEOWNERS became the de-facto standard, there's nothing special about MAINTAINERS that justifies the need for a script. Do we really need a bikeshed to determine the name of a file? Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c42aa058-d084-e4a0-8472-2b0be0bb99da>