Date: Sun, 22 Jul 2001 18:29:15 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Assar Westerlund <assar@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern makeobjops.pl Message-ID: <Pine.BSF.4.21.0107221820100.24295-100000@besplex.bde.org> In-Reply-To: <200107211712.f6LHCjr88023@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Jul 2001, Assar Westerlund wrote:
> assar 2001/07/21 10:12:45 PDT
>
> Modified files:
> sys/kern makeobjops.pl
> Log:
> add <sys/cdefs.h> (for __unused and such)
This is bogus. From style(9):
Kernel include files (i.e. sys/*.h) come first; normally, you'll need
<sys/types.h> OR <sys/param.h>, but not both! <sys/types.h> includes
<sys/cdefs.h>, and it's okay to depend on that.
Including the implementation detail ``<sys/cdefs.h>'' in non-headers
is even more bogus than including both <sys/types.h> and <sys/param.h>.
Only 16 .c files in the entire kernel do it. It is unused in ll 16 of
those (it was used in NetBSD in 6 of those to expand NetBSD rcsid macros).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0107221820100.24295-100000>