Date: Mon, 24 Sep 2007 17:00:14 GMT From: Eugene Grosbein <eugen@grosbein.pp.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints Message-ID: <200709241700.l8OH0EVO089206@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/116536; it has been noted by GNATS. From: Eugene Grosbein <eugen@grosbein.pp.ru> To: bug-followup@freebsd.org Cc: Bruce Evans <brde@optusnet.com.au> Subject: Re: kern/116536: [fdc] [patch] fdc(4) does not respect hint.fd.0.flags from device.hints Date: Tue, 25 Sep 2007 00:56:54 +0800 On Sat, 22 Sep 2007, Bruce Evans wrote: > fd->flags has nothing to do with the device flags. This copy of the device > flags gets clobbered later when fd->flags is used for more-dynamic flags. int has (at least) 32 bits, why not use them? It's possible to move values for user-settable flags (that are broken anyway for now) so that they do not globber with more-dynamic flags. What's the point in calls to device_get_flags() all the way? Eugene Grosbein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709241700.l8OH0EVO089206>