Date: Thu, 3 Feb 2011 14:10:03 -0500 From: Randall Stewart <rrs@lakerest.net> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r218219 - head/sys/netinet Message-ID: <D30C51FF-FD9D-4080-A01C-D8E8116A47F1@lakerest.net> In-Reply-To: <201102030745.34617.jhb@freebsd.org> References: <201102031152.p13BqM8u044432@svn.freebsd.org> <201102030745.34617.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John: Ahh.. thanks for the information .. I did not know that. I will change it to use it.. Before it was using the define.. which as Julian said a while ago was a bad idea. R On Feb 3, 2011, at 7:45 AM, John Baldwin wrote: > On Thursday, February 03, 2011 6:52:22 am Randall Stewart wrote: >> Author: rrs >> Date: Thu Feb 3 11:52:22 2011 >> New Revision: 218219 >> URL: http://svn.freebsd.org/changeset/base/218219 >>=20 >> Log: >> Fix the per CPU stats so that: >> 1) They don't use the giant "MAX_CPU" define and instead >> are allocated dynamically based on mp_ncpus >=20 > You probably want to use mp_maxid instead. CPU IDs are not guaranteed = to be=20 > contiguous (though they currently are). Instead, the only guarantee = are that=20 > there are mp_ncpus CPUs numbered 0 ... mp_maxid. There may be gaps in = that=20 > range (and there have been in the past). >=20 > --=20 > John Baldwin >=20 ------------------------------ Randall Stewart 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D30C51FF-FD9D-4080-A01C-D8E8116A47F1>