Date: Thu, 30 Jun 2005 12:57:43 -0400 From: Suleiman Souhlal <ssouhlal@FreeBSD.org> To: Andreas Tobler <toa@pop.agri.ch> Cc: Current <freebsd-current@FreeBSD.org> Subject: Re: Acquiring lockmgr lock "ufs" with non-sleepable locks Message-ID: <172D31AA-2EFC-4057-AAF7-98B4DA5E4CDA@FreeBSD.org> In-Reply-To: <42C423A9.3010603@pop.agri.ch> References: <7mhdg4q983.wl%kuriyama@imgsrc.co.jp> <C2C1A959-C36C-4A22-93E9-1744B20AC332@FreeBSD.org> <42C30E90.3030405@pop.agri.ch> <59D725CA-BB01-48D5-A2D8-B2D4A9E6B177@FreeBSD.org> <42C423A9.3010603@pop.agri.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 30, 2005, at 12:54 PM, Andreas Tobler wrote: > Hello Suleiman, > > Suleiman Souhlal wrote: > > >>>> This was introduced by my commit to take out the various >>>> kqueue operations outside of ufs. It is because we are trying >>>> to lock the vnode while holding the knlist mutex. I'll work on >>>> a fix on wednesday, as I'll unfortunately be a bit busy until >>>> then. I hope this won't cause you any inconvenience. >>>> >>>> >>> >>> Is the below the same ? >>> >> Yes. >> >>> No, I did not try the follow-up patch yet. >>> >> The patch should fix it. I'll commit it as soon as I get approval. >> > > It did :) Thanks. The tail -f file works now. > > Though, I took the latest diff from your site > (knlist_locking-20050629-2.diff) and had to add the thing below, > you forgot a NULL in knlist_init. > > Regards, > Andreas > > (p.s: patch hand edited) > > Index: src/sys/cam/scsi/scsi_target.c > =================================================================== > --- src/sys/cam/scsi/scsi_target.c (revision 187) > +++ src/sys/cam/scsi/scsi_target.c (working copy) > @@ -196,7 +196,7 @@ > TAILQ_INIT(&softc->work_queue); > TAILQ_INIT(&softc->abort_queue); > TAILQ_INIT(&softc->user_ccb_queue); > - knlist_init(&softc->read_select.si_note, &softc->mtx); > + knlist_init(&softc->read_select.si_note, &softc->mtx, NULL, > NULL, NULL); > > return (0); > } Oops! Thanks! -- Suleiman Souhlal | ssouhlal@vt.edu The FreeBSD Project | ssouhlal@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?172D31AA-2EFC-4057-AAF7-98B4DA5E4CDA>