Date: Sat, 7 Nov 2015 12:16:18 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: Dmitry Morozovsky <marck@rinet.ru> Cc: Bryan Drewery <bryan-lists@shatow.net>, gad@freebsd.org, current@freebsd.org Subject: Re: mtree patch for WITHOUT_LPR Message-ID: <C594780A-5F39-4E34-8CAF-BC9D2728C648@gmail.com> In-Reply-To: <alpine.BSF.2.00.1511072155120.6619@woozle.rinet.ru> References: <alpine.BSF.2.00.1511071404560.6619@woozle.rinet.ru> <563E2EB1.6030005@shatow.net> <alpine.BSF.2.00.1511072012060.6619@woozle.rinet.ru> <alpine.BSF.2.00.1511072108070.6619@woozle.rinet.ru> <B8A33689-A1CA-427E-8121-A325DF75DB8B@gmail.com> <alpine.BSF.2.00.1511072140180.6619@woozle.rinet.ru> <563E4816.6030202@shatow.net> <alpine.BSF.2.00.1511072155120.6619@woozle.rinet.ru>
index | next in thread | previous in thread | raw e-mail
> On Nov 7, 2015, at 10:56, Dmitry Morozovsky <marck@rinet.ru> wrote: > > On Sat, 7 Nov 2015, Bryan Drewery wrote: > >>>>> +/set type=dir uname=root gname=wheel mode=0755 >>>>> +. >>>>> + include >>>>> + atf-c >>>>> + .. >>>>> + atf-c++ >>>>> + .. >>>> >>>> This diff is incorrect. >>> >>> Yes, as Brian noted, this is completely orthogonal. >>> >>>> There are a lot of other things that need to be fixed if we go down this >>>> path. Do you have a plan or idea of what all needs to be fixed? >>> >>> Well, I do not like the idea of tons of micro mtree files; OTOH, it would be >>> great if we could avoid creation of unnecessary directories/files when >>> particular WITHOU_* know is set. >> >> Another way of looking at this problem is that if a directory is in the >> dist mtrees, it should not be listed as an OLD_DIRS. > > ... and this principle I do like much more, yes. It's no harm to have an empty > subtree. Agreed to the above. Some people disagree (and bugs have been filed for it), but as long as there’s a uniform consensus, I think we’ll be fine. Thanks, -NGiehelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C594780A-5F39-4E34-8CAF-BC9D2728C648>