Date: Sat, 23 Mar 2019 23:53:19 -0700 From: Greg Lewis <glewis@eyesbeyond.com> To: Michael Osipov <1983-01-06@gmx.net> Cc: freebsd-java@freebsd.org Subject: Re: openjdk11: include location changed Message-ID: <20190324065319.GB53471@misty.eyesbeyond.com> In-Reply-To: <16376136-18d2-f69a-9f4f-fbea5ca3b781@gmx.net> References: <16376136-18d2-f69a-9f4f-fbea5ca3b781@gmx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 23, 2019 at 07:44:37PM +0100, Michael Osipov wrote: > Folks, > > I continued to test the new port against other projects and failed to > compile jansi-native which is used in Maven. The subtile difference is: > > > [mosipov@mika-ion /usr/ports/java/openjdk8]$ tree /usr/local/openjdk8/include/ > > /usr/local/openjdk8/include/ > > ├── classfile_constants.h > > ├── freebsd > > │ ├── jawt_md.h > > │ └── jni_md.h > > ├── jawt.h > > ├── jdwpTransport.h > > ├── jni.h > > ├── jvmti.h > > └── jvmticmlr.h > > > [mosipov@mika-ion /usr/ports/java/openjdk8]$ tree /usr/local/openjdk11/include/ > > /usr/local/openjdk11/include/ > > ├── bsd > > │ ├── jawt_md.h > > │ └── jni_md.h > > ├── classfile_constants.h > > ├── jawt.h > > ├── jdwpTransport.h > > ├── jni.h > > ├── jvmti.h > > └── jvmticmlr.h > > > freesbd vs bsd > > in ports I see: > > [mosipov@mika-ion /usr/ports/java/openjdk8]$ find . -name jni_md.h > > ./work/openjdk/jdk/src/macosx/javavm/export/jni_md.h > > ./work/openjdk/jdk/src/windows/javavm/export/jni_md.h > > ./work/openjdk/jdk/src/solaris/javavm/export/jni_md.h > > ./work/openjdk/hotspot/src/share/vm/prims/jni_md.h > > > [mosipov@mika-ion /usr/ports/java/openjdk11]$ find . -name jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/src/java.base/unix/native/include/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/src/java.base/windows/native/include/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/support/modules_include/java.base/bsd/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/support/interim-image/include/bsd/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/jdk/include/bsd/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/images/jdk/include/bsd/jni_md.h > > Is that change on purpose? > > Shall I open an issue with Jansi Native? This is an issue with the JDK, that change was not on purpose. In general most software will expect the directory to be freebsd rather than bsd and we should fix that. Can you please open a PR regarding this? -- Greg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190324065319.GB53471>