Date: Sun, 10 Mar 2002 20:29:40 +0000 From: David Malone <dwmalone@maths.tcd.ie> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_linker.c Message-ID: <20020310202940.GA94559@walton.maths.tcd.ie> In-Reply-To: <200203101920.g2AJK1B38135@freefall.freebsd.org> References: <200203101920.g2AJK1B38135@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 10, 2002 at 11:20:01AM -0800, Maxim Sobolev wrote: > sobomax 2002/03/10 11:20:01 PST > > Modified files: > sys/kern kern_linker.c > Log: > Fix a breakage introduced in rev.1.75 (supposedly style cleanup), which results > in "missing dependencies" error when loading some kld modules. It is sad to > see how often these days style cleanus break doesn't broken things. Perhaps > people should recall good old principle: "don't fix it if it isn't broken". Maxim, Would you mind if I chaned all the "err = strcmp() if (err == 0)"s in this file into "if (strcmp() == 0)". The fix I proposed in the PR mentioned by Steven did this (it fixed the same bug and made the strcmps a little more sane). David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020310202940.GA94559>