Date: Wed, 30 Jul 2014 00:07:43 +0300 From: Aleksandr Rybalko <ray@ddteam.net> To: Stefan Farfeleder <stefanf@FreeBSD.org> Cc: svn-src-head@freebsd.org, Aleksandr Rybalko <ray@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r269188 - head/sys/dev/vt Message-ID: <20140730000743.1713fc43ec90a20c888e2511@ddteam.net> In-Reply-To: <20140728143722.GB1263@mole.fafoe.narf.at> References: <201407281422.s6SEMYuC087922@svn.freebsd.org> <20140728143722.GB1263@mole.fafoe.narf.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 28 Jul 2014 16:37:23 +0200 Stefan Farfeleder <stefanf@FreeBSD.org> wrote: > On Mon, Jul 28, 2014 at 02:22:34PM +0000, Aleksandr Rybalko wrote: > > Author: ray > > Date: Mon Jul 28 14:22:34 2014 > > New Revision: 269188 > > URL: http://svnweb.freebsd.org/changeset/base/269188 > > > > Log: > > Avoid embedding buffers into static virtual terminal window. > > > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/sys/dev/vt/vt_core.c > > > > Modified: head/sys/dev/vt/vt_core.c > > ============================================================================== > > --- head/sys/dev/vt/vt_core.c Mon Jul 28 14:20:31 2014 (r269187) > > +++ head/sys/dev/vt/vt_core.c Mon Jul 28 14:22:34 2014 (r269188) > > @@ -166,8 +166,8 @@ static struct vt_window vt_conswindow = > > .vw_number = VT_CONSWINDOW, > > .vw_flags = VWF_CONSOLE, > > .vw_buf = { > > - .vb_buffer = vt_constextbuf, > > - .vb_rows = vt_constextbufrows, > > + .vb_buffer = &vt_constextbuf[0], > > + .vb_rows = &vt_constextbufrows[0], > > .vb_history_size = VBF_DEFAULT_HISTORY_SIZE, > > .vb_curroffset = 0, > > .vb_roffset = 0, > > > > Hi Aleksandr, > > What's that supposed to change exactly? I'd be very surprised if it > didn't produce the same binary code. > > BR, > Stefan Hi Stefan! yeah, you a right, it's change nothing. I did wrong assumption, confuse with other things. But will left it. It looks better for me :) Thanks for review! WBW -- Aleksandr Rybalko <ray@ddteam.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140730000743.1713fc43ec90a20c888e2511>